Add DerivedData to BLACKLISTED_PATTERNS for haste paths#23807
Closed
zhongwuzw wants to merge 1 commit intofacebook:masterfrom
Closed
Add DerivedData to BLACKLISTED_PATTERNS for haste paths#23807zhongwuzw wants to merge 1 commit intofacebook:masterfrom
zhongwuzw wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Mar 13, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @zhongwuzw in 585d41b. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
added
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each time, when I run
iOStests likeRNTesterIntegrationTests, Xcode will copy the bundle inDerivedDatadirectory, and we addedRNTesterUnitTestsBundle.jsto bundle, so it leadsHaste module naming collision, I think we can addDerivedDatadirectory to blacklist.Changelog
[iOS] [Fixed] - Add DerivedData to BLACKLISTED_PATTERNS for haste paths
Test Plan
No
Error: jest-haste-map: Haste module naming collisioncan throw, even though we run the tests.